Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sqllab): Make LeftBar width resizable #21300

Merged

Conversation

justinpark
Copy link
Member

@justinpark justinpark commented Sep 1, 2022

SUMMARY

following feedback from #21280

Since the #21280 can cover too much space by the left bar panel, this commit makes the sidebar width fixed and collapsed the overflowing items as well.

As #20778 introduces the resizable menu on dashboard, this commit refactors the resizable component shareable and then introduces the resizable feature to sqllab left bar so user can expend the width to check the full text on demand.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

  • Before:
sqllab-sidebar--after.mov
  • After:
resizable--sqllab-left-bar.mov

TESTING INSTRUCTIONS

  • Go to sqllab
  • Hover over the left bar divider
  • Drag and drop

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

cc: @EugeneTorap @ktmud

@justinpark justinpark changed the title feat(sqllab): Make LeftBar with resizable feat(sqllab): Make LeftBar width resizable Sep 1, 2022
@justinpark
Copy link
Member Author

cc: @nytai for visibility

@justinpark justinpark force-pushed the feat--make-sqllab-left-bar-resizable branch from 969a1fd to dfa7285 Compare September 1, 2022 20:42
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #21300 (65a11b6) into master (65a11b6) will not change coverage.
The diff coverage is n/a.

❗ Current head 65a11b6 differs from pull request most recent head dfa7285. Consider uploading reports for the commit dfa7285 to get more accurate results

@@           Coverage Diff           @@
##           master   #21300   +/-   ##
=======================================
  Coverage   66.43%   66.43%           
=======================================
  Files        1788     1788           
  Lines       68268    68268           
  Branches     7269     7269           
=======================================
  Hits        45352    45352           
  Misses      21043    21043           
  Partials     1873     1873           
Flag Coverage Δ
hive 53.02% <0.00%> (ø)
javascript 52.47% <0.00%> (ø)
postgres 80.88% <0.00%> (ø)
presto 52.92% <0.00%> (ø)
python 81.32% <0.00%> (ø)
sqlite 79.43% <0.00%> (ø)
unit 50.78% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@EugeneTorap
Copy link
Contributor

Like it 👍

@ktmud ktmud merged commit 2d70ef6 into apache:master Sep 2, 2022
justinpark added a commit to airbnb/superset-fork that referenced this pull request Oct 11, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants