Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix act errors in FaveStar test #21360

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

lyndsiWilliams
Copy link
Member

SUMMARY

This PR fixes 3 act errors in superset-frontend/src/components/FaveStar/FaveStar.test.tsx

TESTING INSTRUCTIONS

  • cd into superset-frontend/src/components/FaveStar
  • run npm run test superset-frontend/src/components/FaveStar/FaveStar.test.tsx
  • Observe that there are no act errors in the console

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #21360 (ba2b9ed) into master (ce3d38d) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head ba2b9ed differs from pull request most recent head 4915ca3. Consider uploading reports for the commit 4915ca3 to get more accurate results

@@            Coverage Diff             @@
##           master   #21360      +/-   ##
==========================================
- Coverage   66.61%   66.59%   -0.03%     
==========================================
  Files        1791     1791              
  Lines       68481    68481              
  Branches     7299     7299              
==========================================
- Hits        45617    45603      -14     
- Misses      20978    20998      +20     
+ Partials     1886     1880       -6     
Flag Coverage Δ
javascript 52.73% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rd/components/nativeFilters/FilterBar/keyValue.tsx 18.51% <0.00%> (-22.23%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 60.14% <0.00%> (-5.80%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -26,13 +26,13 @@ jest.mock('src/components/Tooltip', () => ({
Tooltip: (props: any) => <div data-test="tooltip" {...props} />,
}));

test('render right content', () => {
it('render right content', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it('render right content', async () => {
test('render right content', async () => {

@@ -54,7 +54,7 @@ test('render right content', () => {
expect(props.saveFaveStar).toBeCalledWith(props.itemId, false);
});

test('render content on tooltip', () => {
it('render content on tooltip', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it('render content on tooltip', async () => {
test('render content on tooltip', async () => {

@@ -75,7 +75,7 @@ test('render content on tooltip', () => {
expect(screen.getByRole('button')).toBeInTheDocument();
});

test('Call fetchFaveStar only on the first render', () => {
it('Call fetchFaveStar only on the first render', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it('Call fetchFaveStar only on the first render', async () => {
test('Call fetchFaveStar only on the first render', async () => {

@michael-s-molina michael-s-molina merged commit fd6569e into master Sep 8, 2022
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/favestar-act-cleanup branch September 8, 2022 16:31
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants