fix(dashboard): JS error when editing charts #21422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21422 +/- ##
==========================================
- Coverage 66.55% 66.54% -0.01%
==========================================
Files 1791 1791
Lines 68593 68598 +5
Branches 7319 7320 +1
==========================================
Hits 45651 45651
- Misses 21051 21056 +5
Partials 1891 1891
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
/testenv up |
|
@kgabryje Ephemeral environment spinning up at http://35.88.112.227:8080. Credentials are |
|
Ephemeral environment shutdown and build artifacts deleted. |
justinpark
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Sep 16, 2022
(cherry picked from commit 1084bde)
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
"Edit chart" from dashboard may throw an JS error if the dashboard context is not found in
localStorage. This could happen when users either don't havelocalStorageenabled in there browser (unlikely) or when localStorage has run out of space (for example, ifSQLLAB_BACKEND_PERSISTENCEisn't enabled in SQL Lab).BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
To reproduce the JS error
Go to a Dashboard page
Delete localStorage item
dashboard__explore_context:Go edit any chart in the dashboard
ADDITIONAL INFORMATION