fix: hide time_grain when x_axis value is undefined #21464
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21464 +/- ##
=======================================
Coverage 66.59% 66.59%
=======================================
Files 1791 1791
Lines 68554 68554
Branches 7319 7319
=======================================
Hits 45653 45653
Misses 21008 21008
Partials 1893 1893
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| if (xAxisValue === undefined || isAdhocColumn(xAxisValue)) { | ||
| if (isAdhocColumn(xAxisValue)) { |
There was a problem hiding this comment.
Just to double check, does this work with the FF disabled? I assume this is why that check was put there.
There was a problem hiding this comment.
Yes, it does. Line 329 returns true when FF is disabled.
There was a problem hiding this comment.
Oh right, thanks for clarifying!
| if (xAxisValue === undefined || isAdhocColumn(xAxisValue)) { | ||
| if (isAdhocColumn(xAxisValue)) { |
There was a problem hiding this comment.
Oh right, thanks for clarifying!
mistercrunch
added
🏷️ bot
SUMMARY
The Time Grain Control will be hidden when the value of X_Axis
is undefined. Previously, when x_axisis undefinedthe Time Grain Control would be shown.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After
Before
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION