Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rightmenu): Add Datasets to + Menu and Hide Databases when one has been connected #21530

Merged
merged 6 commits into from
Oct 24, 2022
Merged

feat(rightmenu): Add Datasets to + Menu and Hide Databases when one has been connected #21530

merged 6 commits into from
Oct 24, 2022

Commits on Oct 19, 2022

  1. Right Menu: 

    - check whether user has connected to only examples DB , if so, the plus menu will show Connect Database

- If user has connected any other DB rather than just examples one, we show Connect dataset

- Add tests to right menu
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    54f0d2c View commit details
    Browse the repository at this point in the history

  2. Right Menu: 

    - Change our tests so we can add assertions using the displayed dropdown menus instead of just the setState calls
- Putting back our useState hook
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    36e4854 View commit details
    Browse the repository at this point in the history

  3. Right Menu: 

    - Fix index used to render divider

- Force blue and pointer hover for other menus that are not anchors so they all render the same

- Stop querying the API to get DB info all the time when opening the menu, instead query the API only when opening Data menu
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    c8941a2 View commit details
    Browse the repository at this point in the history

  4. Right Menu: 

    - Update our test file so we include tests for allow_file_upload
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    d29a7bb View commit details
    Browse the repository at this point in the history

  5. Dataset Modal: 

    - Considering using the modal on pages with no SPA routes so CI doesn't fail
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    8079cd0 View commit details
    Browse the repository at this point in the history

  6. Right Menu: 

    - Query non examples DB when user canDatabase OR canDataset
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    78a047d View commit details
    Browse the repository at this point in the history