Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Gsheets takes 2 clicks to save #21740

Merged
merged 2 commits into from
Oct 7, 2022
Merged

fix: Gsheets takes 2 clicks to save #21740

merged 2 commits into from
Oct 7, 2022

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Oct 7, 2022

SUMMARY

Before with gsheet changes, it would take 2 clicks to save a gsheets API. This PR fixes it by making sure the catalog object is in the proper format for the API to ingest.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-10-07.at.6.22.22.PM.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh changed the title fix: transform db to fit payload fix: Gsheets takes 2 clicks to save Oct 7, 2022
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #21740 (1d4554c) into master (a5ff094) will decrease coverage by 0.10%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master   #21740      +/-   ##
==========================================
- Coverage   66.81%   66.71%   -0.11%     
==========================================
  Files        1800     1800              
  Lines       68939    69379     +440     
  Branches     7336     7408      +72     
==========================================
+ Hits        46064    46286     +222     
- Misses      20982    21174     +192     
- Partials     1893     1919      +26     
Flag Coverage Δ
hive ?
javascript 53.26% <40.00%> (+0.10%) ⬆️
mysql 78.24% <ø> (ø)
postgres 78.31% <ø> (ø)
presto 52.81% <ø> (ø)
python 81.24% <ø> (-0.16%) ⬇️
sqlite 76.79% <ø> (?)
unit 50.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/CRUD/hooks.ts 46.39% <40.00%> (-0.17%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 71.14% <0.00%> (-16.21%) ⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js 61.68% <0.00%> (-0.99%) ⬇️
superset/connectors/sqla/models.py 90.51% <0.00%> (-0.18%) ⬇️
superset/utils/core.py 90.21% <0.00%> (-0.11%) ⬇️
superset/db_engine_specs/base.py 89.38% <0.00%> (ø)
superset/views/core.py 76.06% <0.00%> (+0.60%) ⬆️
superset/result_set.py 97.77% <0.00%> (+1.48%) ⬆️
superset/connectors/sqla/utils.py 89.21% <0.00%> (+1.96%) ⬆️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hughhhh hughhhh requested a review from eschutho October 7, 2022 22:22
@hughhhh hughhhh merged commit aef6217 into master Oct 7, 2022
@sadpandajoe
Copy link
Member

🏷️ preset:2022.39

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Oct 7, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the verify-catalog branch March 26, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants