Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump react-map-gl from 4.0.10 to 6.1.19 #21748

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

stephenLYZ
Copy link
Member

@stephenLYZ stephenLYZ commented Oct 9, 2022

SUMMARY

Since there is "Prototype Pollution" in minimist(< 1.2.6), we need to upgrade to 1.2.6. Currently we have two dependecy chains:

  • minimist (0.0.5) -> sharkdown -> @mapbox/geojson-rewind -> mapbox-gl(0.53.1)
  • minimist (0.0.8) -> react-map-gl (4.1.16) -> mapbox-gl(0.54.1)

So just upgrading react-map-gl and mapbox-gl can resolve the issue. However, react-map-gl has break change in version 7 (https://visgl.github.io/react-map-gl/docs/upgrade-guide), we upgrade to version 6 to avoid major changes。

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Merging #21748 (f21a6aa) into master (f58227a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21748   +/-   ##
=======================================
  Coverage   66.84%   66.84%           
=======================================
  Files        1800     1800           
  Lines       68951    68951           
  Branches     7335     7335           
=======================================
  Hits        46092    46092           
- Misses      20965    20966    +1     
+ Partials     1894     1893    -1     
Flag Coverage Δ
javascript 53.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nts/controls/DateFilterControl/DateFilterLabel.tsx 41.41% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhaoyongjie
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

@zhaoyongjie Ephemeral environment spinning up at http://34.222.28.62:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@EugeneTorap
Copy link
Contributor

@stephenLYZ Can we try to update react-map-gl to version 7 in the future in order to minimize our JS bundle?

Version 6 - 1.81 MB

Screenshot 2022-10-09 at 15 34 50

Version 7 - 410 kB

Screenshot 2022-10-09 at 15 35 04

@stephenLYZ
Copy link
Member Author

@stephenLYZ Can we try to update react-map-gl to version 7 in the future in order to minimize our JS bundle?

Version 6 - 1.81 MB

Screenshot 2022-10-09 at 15 34 50

Version 7 - 410 kB

Screenshot 2022-10-09 at 15 35 04

Yeah. The main chart involved is mapbox, which will probably be rewritten in version 7. Let's do it in the another PR

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephenLYZ stephenLYZ merged commit db075d4 into apache:master Oct 11, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants