Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery): Custom message when Service Account doesnt have the correct Roles and Permissions #21838

Merged
merged 5 commits into from
Oct 26, 2022

Commits on Oct 25, 2022

  1. BigQuery:

        - Start sending the message from test connection exceptions instead of a generic exception with no message in it
        - Update the regex CONNECTION_DATABASE_PERMISSIONS_REGEX because google is sending the project name twice now
        - Update tests
    Antonio-RiveroMartnez committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    f842416 View commit details
    Browse the repository at this point in the history
  2. BigQuery:

    - Add the original message ONLY for CONNECTION_DATABASE_PERMISSIONS_ERROR error types so we can keep using the default message for other cases used in other places like tests
    Antonio-RiveroMartnez committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    8c04fa6 View commit details
    Browse the repository at this point in the history
  3. BigQuery:

    - Raise the original DatabaseTestConnectionFailedError exception instead of a new one.
    - Adding normalized_messages method in SupersetErrorsException since the to_dict is not useful for getting the right message to users
    Antonio-RiveroMartnez committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    82d13e5 View commit details
    Browse the repository at this point in the history
  4. BigQuery:

    - Raise the original DatabaseConnectionFailedError from the test command with the right message when necessary
    - Remove the unnecessary code changes to handle multiple errors or DatabaseTestConnectionFailedError exceptions
    Antonio-RiveroMartnez committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    3909223 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. BigQuery:

            - Send a SupersetErrorsException instead of Test one since in the future we will be raising just superset exceptions
            - Update testsq
    Antonio-RiveroMartnez committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    5a11829 View commit details
    Browse the repository at this point in the history