Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check that imports are ZIPs #21875

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

betodealmeida
Copy link
Member

SUMMARY

Check that imports are actually ZIP files.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:

Screenshot 2022-10-19 at 10-01-29 Superset

TESTING INSTRUCTIONS

Working on unit tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@@ -289,7 +289,7 @@ const ImportModelsModal: FunctionComponent<ImportModelsModalProps> = ({
name="modelFile"
id="modelFile"
data-test="model-file-input"
accept=".yaml,.json,.yml,.zip"
accept=".yaml,.json,.yml,.zip,.pdf"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to remove this.

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #21875 (6007d34) into master (54f6fd6) will increase coverage by 0.01%.
The diff coverage is 83.33%.

❗ Current head 6007d34 differs from pull request most recent head a9490b9. Consider uploading reports for the commit a9490b9 to get more accurate results

@@            Coverage Diff             @@
##           master   #21875      +/-   ##
==========================================
+ Coverage   66.90%   66.91%   +0.01%     
==========================================
  Files        1805     1806       +1     
  Lines       69081    69163      +82     
  Branches     7378     7391      +13     
==========================================
+ Hits        46218    46283      +65     
- Misses      20953    20969      +16     
- Partials     1910     1911       +1     
Flag Coverage Δ
hive 52.91% <50.00%> (-0.01%) ⬇️
mysql 78.37% <75.00%> (+0.01%) ⬆️
postgres 78.43% <75.00%> (+0.01%) ⬆️
presto 52.82% <50.00%> (-0.01%) ⬇️
python 81.49% <83.33%> (+0.02%) ⬆️
sqlite 76.91% <75.00%> (+0.01%) ⬆️
unit 51.10% <66.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/charts/api.py 85.76% <75.00%> (-0.27%) ⬇️
superset/queries/saved_queries/api.py 94.44% <75.00%> (-0.84%) ⬇️
superset/databases/api.py 95.55% <100.00%> (+0.02%) ⬆️
...frontend/src/components/Chart/ChartContextMenu.tsx 11.53% <0.00%> (-32.47%) ⬇️
...et-frontend/src/components/Chart/ChartRenderer.jsx 51.25% <0.00%> (-2.18%) ⬇️
superset/initialization/__init__.py 91.00% <0.00%> (-0.47%) ⬇️
...ins/plugin-chart-table/src/DataTable/DataTable.tsx 38.46% <0.00%> (-0.34%) ⬇️
superset/models/core.py 89.79% <0.00%> (-0.33%) ⬇️
superset/views/base.py 75.70% <0.00%> (ø)
superset/examples/tabbed_dashboard.py 0.00% <0.00%> (ø)
... and 24 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after removing the frontend change, also can you add a test also?

@betodealmeida betodealmeida added merge-if-green If approved and tests are green, please go ahead and merge it for me and removed size/M labels Oct 26, 2022
@betodealmeida betodealmeida merged commit a88dfe2 into apache:master Oct 26, 2022
eschutho pushed a commit that referenced this pull request Nov 2, 2022
AAfghahi pushed a commit that referenced this pull request Nov 18, 2022
AAfghahi pushed a commit that referenced this pull request Dec 15, 2022
@mistercrunch mistercrunch added 🍒 1.5.3 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels merge-if-green If approved and tests are green, please go ahead and merge it for me v1.5 v2.0 v2.0.1 🍒 1.5.3 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants