Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump pyathena and related packages #21958

Merged
merged 2 commits into from
Oct 29, 2022

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Oct 27, 2022

SUMMARY

Bumping pyathena and adding in the relevant pandas requirements for that package in order to use the schema pyathena+pandas which was introduced in 2.0. Typing-extensions was also bumped to 4.x for compatibility with other packages.

TESTING INSTRUCTIONS

Creating and running dbs with both rest and pandas drivers for pyathena should now work

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho
Copy link
Member Author

There were some unexpected changes when running pip-compile-multi --no-upgrade on this. It looks like it is updating some of your recent changes here @betodealmeida. Any thoughts?

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #21958 (83f5b6e) into master (196c367) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21958      +/-   ##
==========================================
+ Coverage   66.89%   66.92%   +0.03%     
==========================================
  Files        1805     1805              
  Lines       69055    69117      +62     
  Branches     7366     7366              
==========================================
+ Hits        46197    46260      +63     
+ Misses      20956    20955       -1     
  Partials     1902     1902              
Flag Coverage Δ
hive 52.92% <ø> (+<0.01%) ⬆️
mysql 78.36% <ø> (+0.12%) ⬆️
postgres 78.43% <ø> (+0.12%) ⬆️
presto 52.82% <ø> (+<0.01%) ⬆️
python 81.48% <ø> (+0.03%) ⬆️
sqlite 76.91% <ø> (+0.12%) ⬆️
unit 51.09% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/databases/commands/create.py 86.79% <0.00%> (-5.05%) ⬇️
superset/queries/saved_queries/api.py 94.44% <0.00%> (-0.84%) ⬇️
superset/initialization/__init__.py 91.00% <0.00%> (-0.47%) ⬇️
superset/models/core.py 89.79% <0.00%> (-0.33%) ⬇️
superset/charts/api.py 85.76% <0.00%> (-0.27%) ⬇️
superset/databases/api.py 95.29% <0.00%> (-0.23%) ⬇️
superset/views/base.py 75.70% <0.00%> (ø)
superset/security/manager.py 95.75% <0.00%> (ø)
superset/datasets/commands/create.py 100.00% <0.00%> (ø)
superset/db_engine_specs/bigquery.py 82.05% <0.00%> (ø)
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

# wtforms-json
slack_sdk==3.18.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did something change here?

Copy link
Member

@betodealmeida betodealmeida Oct 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _ for -. ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah good eye

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Rant: I always cringe at the fact that - and _ can be used interchangeably for Python deps.. 😡

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, bumping always makes me feel warm and fuzzy inside! 😄 LGTM with a few non-blocking comments

# wtforms-json
slack_sdk==3.18.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Rant: I always cringe at the fact that - and _ can be used interchangeably for Python deps.. 😡

setup.py Show resolved Hide resolved
@eschutho eschutho closed this Oct 28, 2022
@eschutho eschutho reopened this Oct 28, 2022
@eschutho eschutho merged commit efefb66 into apache:master Oct 29, 2022
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Oct 31, 2022
@sadpandajoe
Copy link
Member

🏷️ preset:2022.43

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.43 size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants