Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Flask-Babel links #22023

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

haocheng6
Copy link
Contributor

@haocheng6 haocheng6 commented Nov 3, 2022

SUMMARY

  • This PR updates Flask-Babel links in the documentation site because the old links do not work now.
  • This PR also updates the Babel link in the contributing guide to make it consistent with the documentation site.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Build the documentation site locally and verify that the new links work as expected.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

@rusackas rusackas merged commit 3df1c99 into apache:master Dec 2, 2022
@rusackas
Copy link
Member

rusackas commented Dec 2, 2022

Thanks for the updates, @haocheng6! We always love it when people help touch up the documentation. If you have further interest in this effort, ping us here or on Slack!

@haocheng6 haocheng6 deleted the docs/translation-links branch December 21, 2022 17:00
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants