fix(dashboard): Fix FilterWithDataMask typing and add null check #22260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyml
changed the title
9 tasks
codyml
changed the title
villebro
approved these changes
Nov 29, 2022
zhaoyongjie
reviewed
Nov 30, 2022
| @@ -128,7 +128,7 @@ const FilterControls: FC<FilterControlsProps> = ({ | |||
| const activeOverflowedFiltersInScope = useMemo( | |||
| () => | |||
| overflowedFiltersInScope.filter( | |||
| filter => isNativeFilter(filter) && filter.dataMask.filterState?.value, | |||
| filter => isNativeFilter(filter) && filter.dataMask?.filterState?.value, | |||
There was a problem hiding this comment.
Currently, there are isNativeFilter and isFilterDivider as the type guard, so I think we should introduce a new type guard for this use case, for example, isFilterWithDataMask.
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes a typing error that enabled an undefined key access error:
dataMaskisn't guaranteed to exist on typeFilterWithDataMaskbecause the source of that key,DataMaskStateWithId, isn't guaranteed to have a value for each filter ID.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Example of error:
TESTING INSTRUCTIONS
I had trouble reproducing this issue locally, but try various combinations of filled and unfilled filters and ensure that it doesn't happen again.
ADDITIONAL INFORMATION
HORIZONTAL_FILTER_BAR