Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handles disable Select All on Value Selection #23358

Closed
wants to merge 2 commits into from

Conversation

sinhashubham95
Copy link
Contributor

SUMMARY

Once a value is selected in Select, the Select All option should be disabled. This is because the Select supports the Enter key, and it is very likely for that to be pressed twice. Once a value is selected using Enter, and Enter is pressed twice, then instead of 1 value all values(Select All) gets selected.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sinhashubham95! Need to update some tests in the Select component since this change is breaking them, for example: do not count unselected disabled options in "Select All"

@michael-s-molina
Copy link
Member

Hi @sinhashubham95. The Enter key acts on the current focused item on the list. I did a quick test here, and if you navigate using the arrow keys to a particular item, press Enter, the item will be selected. If you press Enter again, the item will be deselected. Can you record a video of the behavior you described?

@michael-s-molina
Copy link
Member

@sinhashubham95 I'm linking a recent fix #23400 that may or may not be related to what you described.

@sinhashubham95
Copy link
Contributor Author

Thanks @michael-s-molina. Let me try it out. I was unavailable this week. Will try to get back today on this.

@michael-s-molina
Copy link
Member

Closing this PR for now as it seems this issue was resolved. @sinhashubham95 feel free to reopen it in case the issue is still present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants