Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sankey): Return the exact faulty link instead of root #23444

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(sankey): Return the exact faulty link instead of root #23444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions superset/viz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1973,8 +1973,9 @@
def visit(vertex: str) -> Optional[Tuple[str, str]]:
path.add(vertex)
for neighbour in graph.get(vertex, ()):
if neighbour in path or visit(neighbour):
return (vertex, neighbour)
cycle = (vertex, neighbour) if neighbour in path else visit(neighbour)

Check warning on line 1976 in superset/viz.py

View check run for this annotation

Codecov / codecov/patch

superset/viz.py#L1976 

Added line #L1976 was not covered by tests
if cycle:
return cycle

Check warning on line 1978 in superset/viz.py

View check run for this annotation

Codecov / codecov/patch

superset/viz.py#L1978 

Added line #L1978 was not covered by tests
path.remove(vertex)
return None

Expand Down
Loading