docs(security): more context around Talisman, note side effect of force_https on Alerts & Reports #23537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytai
approved these changes
Mar 30, 2023
rusackas
reviewed
Apr 5, 2023
rusackas
reviewed
Apr 5, 2023
rusackas
reviewed
Apr 5, 2023
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing a Content Security Policy as described in the current Security docs may break Alerts & Reports because of the other default arguments to Talisman. Those are not currently documented.
This PR notes the existence of those arguments, describes that the default value of
force_httpsmay break Reports, and provides a solution (set it to False).Thanks to @nytai for debugging this in Slack.