Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add metadata bar to drill by modal #23542

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

kgabryje
Copy link
Member

SUMMARY

Refactors useDatasetMetadataBar so that it can used cached requests data + adds the dataset metadata bar to drill by modal.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #23542 (caa22d1) into master (4452a65) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head caa22d1 differs from pull request most recent head 3b5be8a. Consider uploading reports for the commit 3b5be8a to get more accurate results

@@           Coverage Diff           @@
##           master   #23542   +/-   ##
=======================================
  Coverage   67.70%   67.71%           
=======================================
  Files        1916     1916           
  Lines       74009    74020   +11     
  Branches     8038     8041    +3     
=======================================
+ Hits        50111    50122   +11     
  Misses      21848    21848           
  Partials     2050     2050           
Flag Coverage Δ
javascript 53.94% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/components/Chart/DrillBy/DrillByChart.tsx 92.85% <100.00%> (ø)
.../src/components/Chart/DrillBy/DrillByMenuItems.tsx 85.71% <100.00%> (+0.46%) ⬆️
...tend/src/components/Chart/DrillBy/DrillByModal.tsx 91.66% <100.00%> (+0.75%) ⬆️
...c/components/Chart/DrillDetail/DrillDetailPane.tsx 75.32% <100.00%> (ø)
...res/datasets/metadataBar/useDatasetMetadataBar.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@lilykuang lilykuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kgabryje kgabryje merged commit d966db6 into apache:master Apr 4, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants