fix(dash import): Ensure old datasource ids are not referenced in imported charts #23582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfrag1
changed the title
Codecov Report
@@ Coverage Diff @@
## master #23582 +/- ##
=======================================
Coverage 67.71% 67.72%
=======================================
Files 1916 1916
Lines 74014 74019 +5
Branches 8039 8039
=======================================
+ Hits 50122 50126 +4
- Misses 21843 21844 +1
Partials 2049 2049
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eschutho
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
lgtm but @betodealmeida may be more familiar with this code.
betodealmeida
approved these changes
Apr 5, 2023
betodealmeida
deleted the
jack/fix-dash-import-params-and-query-context-on-charts
branch
|
Thanks! I was exactly looking for this. So If I import any dashboard from let say 1.5.1 to 2.1.1, it should not produce the false alarm. |
eschutho
pushed a commit
to preset-io/superset
that referenced
this pull request
May 23, 2023
…orted charts (apache#23582) (cherry picked from commit 7034401)
vik4114
added a commit
to vik4114/superset
that referenced
this pull request
May 25, 2023
jfrag1
added a commit
to preset-io/superset
that referenced
this pull request
Aug 25, 2023
9 tasks
mistercrunch
added
🍒 2.1.1
🍒 2.1.2
🍒 2.1.3
🏷️ bot
3 tasks
denodo-research-labs
pushed a commit
to denodo-research-labs/superset
that referenced
this pull request
Aug 13, 2024
…orted charts (apache#23582) (cherry picked from commit 7034401)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently, charts imported via a dashboard import contain references to the chart's old datasource id from when it was exported within their
paramsandquery_context. This didn't result in any functionality breaking, but it would result in the following "false alarm" error message when loading the dashboard:There is precedent for this fix in the individual chart import, see here: https://github.com/apache/superset/blob/master/superset/charts/commands/importers/v1/__init__.py#L96
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION