feat(presto): get_catalog_names

[betodealmeida]

SUMMARY

Implement get_catalog_names for Presto/Trino. This is needed to support catalog-level permissions, and also for #22862.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

I configured a Trino database and ran this script:

from superset.app import create_app

app = create_app()
with app.app_context():
    from superset import db
    from superset.db_engine_specs.presto import PrestoEngineSpec
    from superset.models.core import Database

    database = db.session.query(Database).first()
    with database.get_inspector_with_context() as inspector:
        print(PrestoEngineSpec.get_catalog_names(database, inspector))

When ran, it produced the expected output:

['jmx', 'memory', 'mysql', 'system', 'tpcds', 'tpch']  

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #23599 (9fda8fd) into master (56dcf25) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

❗ Current head 9fda8fd differs from pull request most recent head 0105645. Consider uploading reports for the commit 0105645 to get more accurate results

@@            Coverage Diff             @@
##           master   #23599      +/-   ##
==========================================
- Coverage   67.72%   67.72%   -0.01%     
==========================================
  Files        1916     1916              
  Lines       74051    74054       +3     
  Branches     8040     8040              
==========================================
+ Hits        50153    50155       +2     
- Misses      21850    21851       +1     
  Partials     2048     2048              

Flag	Coverage Δ
hive	52.75% <66.66%> (+<0.01%)	⬆️
mysql	78.49% <66.66%> (-0.01%)	⬇️
postgres	78.57% <66.66%> (-0.01%)	⬇️
presto	52.68% <66.66%> (+<0.01%)	⬆️
python	82.41% <66.66%> (-0.01%)	⬇️
sqlite	77.07% <66.66%> (-0.01%)	⬇️
unit	52.65% <66.66%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/db_engine_specs/postgres.py	97.10% <ø> (ø)
superset/db_engine_specs/presto.py	87.91% <66.66%> (-0.14%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[Antonio-RiveroMartnez]

Curious about why this had to change?

[betodealmeida]

@Antonio-RiveroMartnez in this case it's redundant, the expression generator will implicitly call fetchall() here. Eg:

>>> from sqlalchemy import create_engine
>>> engine = create_engine("shillelagh://")
>>> url = "https://docs.google.com/spreadsheets/d/1LcWZMsdCl92g7nA-D6qGRqg1T5TiHyuKJUY1u9XAnsk/edit#gid=0"
>>> engine.execute(f'SELECT * FROM "{url}"').fetchall()
[('BR', 2), ('BR', 4), ('ZA', 7), ('CR', 11), ('CR', 11), ('FR', 100), ('AR', 42)]
>>> [row for row in engine.execute(f'SELECT * FROM "{url}"')]
[('BR', 2), ('BR', 4), ('ZA', 7), ('CR', 11), ('CR', 11), ('FR', 100), ('AR', 42)]