Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: bump to Python3.9 #23890

Merged
merged 15 commits into from
May 10, 2023
Merged

feat!: bump to Python3.9 #23890

merged 15 commits into from
May 10, 2023

Conversation

sebastianliebscher
Copy link
Contributor

@sebastianliebscher sebastianliebscher commented May 1, 2023 •
edited
Loading

SUMMARY

Running CI integration and unit tests for Python 3.9 is a first step to fully upgrade official release to Python 3.10.
This PR bumps Python to version 3.9:

Also, added double quotes around strategy.matrix.python-versions values as without quotes, e.g. 3.10 is interpreted as 3.1 reference to GitHub Actions Doc

TESTING INSTRUCTIONS

All existing and new CI jobs run without errors.

@codecov
Copy link

codecov bot commented May 1, 2023 •
edited
Loading

Codecov Report

Merging #23890 (0e520ae) into master (7757b61) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 0e520ae differs from pull request most recent head 3b7e1f9. Consider uploading reports for the commit 3b7e1f9 to get more accurate results

@@            Coverage Diff             @@
##           master   #23890      +/-   ##
==========================================
+ Coverage   68.19%   68.21%   +0.02%     
==========================================
  Files        1941     1941              
  Lines       75277    75302      +25     
  Branches     8166     8166              
==========================================
+ Hits        51333    51371      +38     
+ Misses      21855    21842      -13     
  Partials     2089     2089
Flag Coverage Δ
hive 53.18% <ø> (+<0.01%) ⬆️
mysql 78.91% <ø> (?)
postgres 78.98% <ø> (+<0.01%) ⬆️
presto 53.09% <ø> (+<0.01%) ⬆️
python 82.75% <ø> (+0.04%) ⬆️
sqlite 77.51% <ø> (+0.01%) ⬆️
unit 53.00% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 17 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pull-request-size pull-request-size bot added size/S and removed size/XS labels May 2, 2023
@sebastianliebscher sebastianliebscher changed the title feat: run ci unit+integration tests for py310 feat(ci): run unit+integration tests for py310 May 2, 2023
@villebro
Copy link
Member

villebro commented May 2, 2023

@sebastianliebscher is adding quotes around the python version the "correct" way? It would be nice to add a note about that in the description.

@sebastianliebscher
Copy link
Contributor Author

sebastianliebscher commented May 2, 2023 •
edited
Loading

@villebro Without the quotes, e.g. 3.10 is interpreted as 3.1. But you are right, I missed that in the desciption. I updated the desciption accordingly 👍

@villebro
Copy link
Member

villebro commented May 2, 2023

@villebro Without the quotes, e.g. 3.10 is interpreted as 3.1. But you are right, I missed that in the desciption. I updated the desciption accordingly 👍

Thanks @sebastianliebscher - makes sense 👍

@pull-request-size pull-request-size bot added size/M and removed size/S labels May 8, 2023
@sebastianliebscher sebastianliebscher changed the title feat(ci): run unit+integration tests for py310 feat: bump Python3.9 May 9, 2023
@sebastianliebscher sebastianliebscher changed the title feat: bump Python3.9 feat: bump to Python3.9 May 9, 2023
villebro
villebro reviewed May 10, 2023
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few quick comments

.asf.yaml Outdated Show resolved Hide resolved
scripts/benchmark_migration.py Outdated Show resolved Hide resolved
@EugeneTorap EugeneTorap mentioned this pull request May 10, 2023
Merged
9 tasks
dpgaspar
dpgaspar reviewed May 10, 2023
View reviewed changes
Dockerfile Show resolved Hide resolved
dpgaspar
dpgaspar approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thank you @sebastianliebscher this is great!

villebro
villebro approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, exciting! 🚀 @sebastianliebscher let's rebase to restart CI

@sebastianliebscher
Copy link
Contributor Author

Also many thanks to @EugeneTorap, great team effort :)

@EugeneTorap EugeneTorap force-pushed the update-python-ci branch 3 times, most recently from 7b9f63f to 708b000 Compare May 10, 2023 16:13
@villebro villebro merged commit e3719a1 into apache:master May 10, 2023
@EugeneTorap EugeneTorap deleted the update-python-ci branch May 10, 2023 17:27
animesh-kumar9779 added a commit to animesh-kumar9779/superset that referenced this pull request May 10, 2023
@animesh-kumar9779
Revert "feat: bump to Python3.9 (apache#23890)"
23bb315 
This reverts commit e3719a1.
@mdeshmu mdeshmu mentioned this pull request May 12, 2023
Closed
9 tasks
@eschutho eschutho added the risk:breaking-change Issues or PRs that will introduce breaking changes label May 15, 2023
@eschutho eschutho changed the title feat: bump to Python3.9 feat!: bump to Python3.9 May 15, 2023
@eschutho
Copy link
Member

I marked this as a breaking change. All good for now since we can get it into the 3.0 release.

eschutho
eschutho reviewed May 15, 2023
View reviewed changes
UPDATING.md
@@ -46,6 +46,7 @@ assists people when migrating to a new version.
- [21163](https://github.com/apache/superset/pull/21163): The time grain will be decoupled from the time filter column and the time grain control will move below the X-Axis control when `GENERIC_CHART_AXES` feature flags set to `True`. The time grain will be applied on the time column in the column-like controls(x axis, dimensions) instead of the time column in the time section.
- [21284](https://github.com/apache/superset/pull/21284): The non-functional `MAX_TABLE_NAMES` config key has been removed.
- [21794](https://github.com/apache/superset/pull/21794): Deprecates the undocumented `PRESTO_SPLIT_VIEWS_FROM_TABLES` feature flag. Now for Presto, like other engines, only physical tables are treated as tables.
- [23890](https://github.com/apache/superset/pull/23890): Removes Python 3.8 support.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to create a PR to update this file for 2.1, so I'll move this into Breaking Changes then.

This was referenced May 19, 2023
Merged
Merged
@michael-s-molina michael-s-molina mentioned this pull request Jun 28, 2023
Merged
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EugeneTorap EugeneTorap EugeneTorap left review comments

@eschutho eschutho eschutho left review comments

@villebro villebro villebro approved these changes

@dpgaspar dpgaspar dpgaspar approved these changes

@geido geido Awaiting requested review from geido geido is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@mistercrunch mistercrunch Awaiting requested review from mistercrunch mistercrunch is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley john-bodley is a code owner

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:breaking-change Issues or PRs that will introduce breaking changes size/M 🚢 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sebastianliebscher @villebro @eschutho @dpgaspar @EugeneTorap @mistercrunch