Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reorder k-v migration for 2.1.1 #24306

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

villebro
Copy link
Member

@villebro villebro commented Jun 7, 2023

SUMMARY

Reorder a few migrations for the 2.1.1 release. This is needed to cherry in the key-value pickle removal PR.

Original order:

4ce1d9b25135
f3c2d8ec8595
<2.1.0 cutoff>
<2.1.1 cutoff>
c0a3ea245b61
...
7e67aecbf3f1
9c2a5681ddfd (pickle key-value migration)
4ea966691069

New order:

4ce1d9b25135
f3c2d8ec8595
<2.1.0 cutoff>
9c2a5681ddfd (pickle key-value migration)
<2.1.1 cutoff>
c0a3ea245b61
...
7e67aecbf3f1
4ea966691069

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro requested a review from a team as a code owner June 7, 2023 10:31
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #24306 (fc91207) into master (ede6acd) will increase coverage by 1.78%.
The diff coverage is n/a.

❗ Current head fc91207 differs from pull request most recent head 2c5b970. Consider uploading reports for the commit 2c5b970 to get more accurate results

@@            Coverage Diff             @@
##           master   #24306      +/-   ##
==========================================
+ Coverage   66.53%   68.31%   +1.78%     
==========================================
  Files        1957     1957              
  Lines       75623    75623              
  Branches     8224     8224              
==========================================
+ Hits        50312    51662    +1350     
+ Misses      23202    21852    -1350     
  Partials     2109     2109              
Flag Coverage Δ
hive 53.39% <ø> (?)
mysql 78.92% <ø> (ø)
postgres 79.00% <ø> (ø)
presto 53.32% <ø> (?)
python 82.82% <ø> (+3.69%) ⬆️
sqlite 77.53% <ø> (ø)
unit 53.44% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 95 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@villebro villebro changed the title [WIP] chore: reorder k-v migration for 2.1 chore: reorder k-v migration for 2.1.1 Jun 7, 2023
@michael-s-molina
Copy link
Member

michael-s-molina commented Jun 7, 2023

@john-bodley Could you check if this re-ordering will affect our release or if it's ok to merge it?

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 5d3c1d2 into apache:master Jun 7, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants