Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts): Fix chart load task error handling #24447

Merged
merged 1 commit into from
Jun 21, 2023

Commits on Jun 21, 2023

  1. fix(charts): Fix chart load task error handling

    The exceptions raised within this task are given internationalised
    messages (flask-babel), which means when the task tries to serialise the
    exception message to mark the job as failed, it needs to make sure
    they're rendered first. Cast to str to make that happen.
    
    The underlying issue was using lazy_gettext when just using gettext
    would make more sense, so I've also adjusted the import in a couple of
    obvious places directly impacting this task to fix it at both ends.
    
    I've left in the str cast fix as it'd require a much deeper dive to
    determine if any other edge cases would still result in a lazy message
    given the complexity of the task.
    
    Add a unit test covering this scenario as the task is currently not
    covered
    giftig committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    2f9d48a View commit details
    Browse the repository at this point in the history