Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SQL Lab - correct setting name from DISPLAY_MAX_ROWS to DISPLAY_MAX_ROW #24519

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

jgillick
Copy link
Contributor

SUMMARY

The warning message when results are truncated references the wrong config setting: DISPLAY_MAX_ROWS (plural)

TESTING INSTRUCTIONS

  • Run a query that returns more than the default row limit.
  • The warning should display the correct config setting: DISPLAY_MAX_ROW

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@john-bodley
Copy link
Member

Thanks @jgillick for the fix.

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #24519 (2b80c3c) into master (036294a) will not change coverage.
The diff coverage is n/a.

❗ Current head 2b80c3c differs from pull request most recent head 7f9cda7. Consider uploading reports for the commit 7f9cda7 to get more accurate results

@@           Coverage Diff           @@
##           master   #24519   +/-   ##
=======================================
  Coverage   69.07%   69.07%           
=======================================
  Files        1902     1902           
  Lines       74024    74024           
  Branches     8117     8117           
=======================================
  Hits        51134    51134           
  Misses      20779    20779           
  Partials     2111     2111           
Flag Coverage Δ
hive 53.89% <ø> (ø)
javascript 55.74% <ø> (ø)
mysql 79.41% <ø> (ø)
postgres 79.50% <ø> (ø)
presto 53.79% <ø> (ø)
python 83.49% <ø> (ø)
sqlite 78.00% <ø> (ø)
unit 54.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/SqlLab/components/ResultSet/index.tsx 63.05% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jgillick jgillick changed the title Fix:(SqlLab) correct setting name from DISPLAY_MAX_ROWS to DISPLAY_MAX_ROW fix:(SqlLab) correct setting name from DISPLAY_MAX_ROWS to DISPLAY_MAX_ROW Jun 27, 2023
@michael-s-molina michael-s-molina changed the title fix:(SqlLab) correct setting name from DISPLAY_MAX_ROWS to DISPLAY_MAX_ROW fix: SQL Lab - correct setting name from DISPLAY_MAX_ROWS to DISPLAY_MAX_ROW Jun 28, 2023
@michael-s-molina michael-s-molina merged commit 71f3fca into apache:master Jun 28, 2023
32 of 34 checks passed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants