Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade visx #24723

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: upgrade visx #24723

wants to merge 1 commit into from

Conversation

lilykuang
Copy link
Member

@lilykuang lilykuang commented Jul 18, 2023

SUMMARY

Not Found - GET https://registry.npmjs.org/@vx/tooltip/-/tooltip-0.0.140.tgz - Not found
'@vx/tooltip@https://registry.npmjs.org/@vx/tooltip/-/tooltip-0.0.140.tgz' is not in this registry.

This pr is for upgrading visx to fix the error

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #24723 (f72fce7) into master (837e3c5) will not change coverage.
The diff coverage is n/a.

❗ Current head f72fce7 differs from pull request most recent head ba1b078. Consider uploading reports for the commit ba1b078 to get more accurate results

@@           Coverage Diff           @@
##           master   #24723   +/-   ##
=======================================
  Coverage   68.89%   68.89%           
=======================================
  Files        1901     1901           
  Lines       73927    73927           
  Branches     8183     8183           
=======================================
  Hits        50932    50932           
  Misses      20874    20874           
  Partials     2121     2121           
Flag Coverage Δ
javascript 55.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@john-bodley
Copy link
Member

@lilykuang would you mind adding a PR description which will help reviewers grok the impact of the change?

@lilykuang
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@lilykuang Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

@lilykuang Ephemeral environment creation failed. Please check the Actions logs for details.

@lilykuang
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@lilykuang Ephemeral environment spinning up at http://54.184.229.218:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas
Copy link
Member

/testenv down

@rusackas
Copy link
Member

/testenv up

Copy link
Contributor

@rusackas Container image not yet published for this PR. Please try again when build is complete.

Copy link
Contributor

@rusackas Ephemeral environment creation failed. Please check the Actions logs for details.

@rusackas
Copy link
Member

Hey @lilykuang hope all is well! :D

Would you be able to give this a quick rebase so we can get it through, perchance? Sorry it seems to have fallen between the proverbial couch cushions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants