Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump PyYAML bounds #24731

Merged
merged 1 commit into from
Jul 18, 2023
Merged

chore: Bump PyYAML bounds #24731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions requirements/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,7 @@ humanize==3.11.0
idna==3.2
# via email-validator
importlib-metadata==6.6.0
# via
# apache-superset
# flask
# via apache-superset
importlib-resources==5.12.0
# via limits
isodate==0.6.0
Expand Down Expand Up @@ -243,7 +241,7 @@ pytz==2021.3
# celery
# flask-babel
# pandas
pyyaml==5.4.1
pyyaml==6.0.1
# via
# apache-superset
# apispec
Expand Down Expand Up @@ -318,9 +316,7 @@ wtforms-json==0.3.5
xlsxwriter==3.0.7
# via apache-superset
zipp==3.15.0
# via
# importlib-metadata
# importlib-resources
# via importlib-metadata

# The following packages are considered to be unsafe in a requirements file:
# setuptools
13 changes: 9 additions & 4 deletions requirements/integration.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ packaging==23.1
# pyproject-api
# tox
pip-compile-multi==2.6.3
# via -r integration.in
# via -r requirements/integration.in
pip-tools==6.13.0
# via pip-compile-multi
platformdirs==3.8.1
Expand All @@ -45,17 +45,22 @@ platformdirs==3.8.1
pluggy==1.2.0
# via tox
pre-commit==3.3.3
# via -r integration.in
# via -r requirements/integration.in
pyproject-api==1.5.2
# via tox
pyproject-hooks==1.0.0
# via build
pyyaml==5.4.1
pyyaml==6.0.1
# via pre-commit
tomli==2.0.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this wasn't present previously. Possibly a problematic failed prior run of pip-compile-multi and/or pinning requirements outside of said tool.

# via
# build
# pyproject-api
# tox
toposort==1.10
# via pip-compile-multi
tox==4.6.4
# via -r integration.in
# via -r requirements/integration.in
virtualenv==20.23.1
# via
# pre-commit
Expand Down
4 changes: 4 additions & 0 deletions requirements/testing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ cmdstanpy==1.1.0
# via prophet
contourpy==1.0.7
# via matplotlib
convertdate==2.4.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment.

# via prophet
coverage[toml]==7.2.5
# via pytest-cov
cycler==0.11.0
Expand Down Expand Up @@ -121,6 +123,8 @@ pyfakefs==5.2.2
# via -r requirements/testing.in
pyhive[presto]==0.6.5
# via apache-superset
pymeeus==0.5.12
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment.

# via convertdate
pytest==7.3.1
# via
# -r requirements/testing.in
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def get_git_sha() -> str:
"python-dotenv",
"python-geohash",
"pyarrow>=12.0.0, <13",
"pyyaml>=5.4",
"pyyaml>=6.0.0, <7.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A side note. It likely would be good (in a follow up PR) to:

  1. Add bounds to all packages.
  2. Ensure consistent version specification, i.e., adhere to the <major>.<minor>.<patch> version construct (if applicable).

"PyJWT>=2.4.0, <3.0",
"redis>=4.5.4, <5.0",
"selenium>=3.141.0, <4.10.0",
Expand Down
Loading