Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(connector): Cleanup base models and views according to SIP-92 #24773

Merged
merged 1 commit into from
Nov 21, 2023
Merged

chore(connector): Cleanup base models and views according to SIP-92 #24773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset/charts/data/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
from superset.charts.post_processing import apply_post_process
from superset.charts.schemas import ChartDataQueryContextSchema
from superset.common.chart_data import ChartDataResultFormat, ChartDataResultType
from superset.connectors.base.models import BaseDatasource
from superset.connectors.sqla.models import BaseDatasource
from superset.daos.exceptions import DatasourceNotFound
from superset.exceptions import QueryObjectValidationError
from superset.extensions import event_logger
Expand Down
2 changes: 1 addition & 1 deletion superset/charts/post_processing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
)

if TYPE_CHECKING:
from superset.connectors.base.models import BaseDatasource
from superset.connectors.sqla.models import BaseDatasource
from superset.models.sql_lab import Query


Expand Down
2 changes: 1 addition & 1 deletion superset/commands/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
from superset.utils.core import DatasourceType, get_user_id

if TYPE_CHECKING:
from superset.connectors.base.models import BaseDatasource
from superset.connectors.sqla.models import BaseDatasource


def populate_owners(
Expand Down
2 changes: 1 addition & 1 deletion superset/common/query_actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
from superset import app
from superset.common.chart_data import ChartDataResultType
from superset.common.db_query_status import QueryStatus
from superset.connectors.base.models import BaseDatasource
from superset.connectors.sqla.models import BaseDatasource
from superset.exceptions import QueryObjectValidationError
from superset.utils.core import (
extract_column_dtype,
Expand Down
2 changes: 1 addition & 1 deletion superset/common/query_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
from superset.models.slice import Slice

if TYPE_CHECKING:
from superset.connectors.base.models import BaseDatasource
from superset.connectors.sqla.models import BaseDatasource
from superset.models.helpers import QueryResult


Expand Down
2 changes: 1 addition & 1 deletion superset/common/query_context_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
from superset.utils.core import DatasourceDict, DatasourceType, is_adhoc_column

if TYPE_CHECKING:
from superset.connectors.base.models import BaseDatasource
from superset.connectors.sqla.models import BaseDatasource

config = app.config

Expand Down
2 changes: 1 addition & 1 deletion superset/common/query_context_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
get_since_until_from_query_object,
get_since_until_from_time_range,
)
from superset.connectors.base.models import BaseDatasource
from superset.connectors.sqla.models import BaseDatasource
from superset.constants import CacheRegion, TimeGrain
from superset.daos.annotation import AnnotationLayerDAO
from superset.daos.chart import ChartDAO
Expand Down
2 changes: 1 addition & 1 deletion superset/common/query_object.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
from superset.utils.hashing import md5_sha_from_dict

if TYPE_CHECKING:
from superset.connectors.base.models import BaseDatasource
from superset.connectors.sqla.models import BaseDatasource

logger = logging.getLogger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion superset/common/query_object_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
if TYPE_CHECKING:
from sqlalchemy.orm import sessionmaker

from superset.connectors.base.models import BaseDatasource
from superset.connectors.sqla.models import BaseDatasource
from superset.daos.datasource import DatasourceDAO


Expand Down
16 changes: 0 additions & 16 deletions superset/connectors/base/__init__.py
View file
Open in desktop

This file was deleted.

Loading
Loading