Commits on Aug 2, 2023

1. fix(sqllab): Force trino client async execution …

   We are currently unable to stop trino queries, because the underlying
   trino client blocks until the query completes, and doesn't make the
   query ID or any other info available in the meantime. Unfortunately it
   doesn't look like they plan to change that any time soon, either.
   
   Make the following changes:
     - Add a new method execute_with_cursor to db_engine_spec which
       combines execute with handle_cursor, factoring it out of the one
       place it's used, deep in the execute query logic.
     - Make handle_cursor poll the cursor for query ID, as it's going to
       be populated asynchronously. Add warnings that the trino impl will
       require using execute_with_cursor. Currently nothing is directly
       calling handle_cursor, with the one original call eliminated.
     - Override execute_with_cursor for the trino engine and execute the
       two tasks in parallel to allow us to poll for the query ID
       while the query is still blocking.

   

   giftig committed Aug 2, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 4919b58
   • Browse repository at this point

   Copy the full SHA

   4919b58 View commit details

   Browse the repository at this point in the history