fix: calls to _get_sqla_engine
#24953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
commented
Aug 10, 2023
superset/models/core.py
Outdated
Comment on lines
673
to
674
| with self.get_sqla_engine_with_context() as engine: | ||
| return sqla.inspect(engine) |
There was a problem hiding this comment.
I think this will fail and the inspector will have a reference to a closed engine; we need to refactor it.
betodealmeida
force-pushed
the
fix_get_sqla_engine
branch
from
e2bc0e8
to
9412cf8
Compare
hughhhh
approved these changes
Aug 11, 2023
michael-s-molina
added
the
v3.0
michael-s-molina
pushed a commit
that referenced
this pull request
Aug 14, 2023
(cherry picked from commit 6f24a4e)
mistercrunch
added
🍒 3.0.0
🍒 3.0.1
🍒 3.0.2
🍒 3.0.3
🍒 3.0.4
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There are a few places in
superset/modelwhere we call_get_sqla_enginedirectly, instead of callingget_sqla_engine_with_context() as engine:. These methods will fail if SSH is configured.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION