Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): Spelling #25453

Merged
merged 11 commits into from
Sep 29, 2023
Merged

chore(docs): Spelling #25453

merged 11 commits into from
Sep 29, 2023

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Sep 28, 2023

SUMMARY

I think most of these were discussed in #19648 but never merged...

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@jsoref
spelling: authentication
49f0dd3 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: below
a6c8b0d 
Signed-off-by: Josh Soref <[email protected]>
@jsoref jsoref changed the title Spelling docs chore(docs): Spelling Sep 28, 2023
@jsoref
spelling: database
cb0a458 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: datasource
87b3ca4 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: github
e59887f 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: into
8b22009 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: malformed
2b975a0 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: please
02fea48 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: preexisting
9d86e2c 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: this
89baf08 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: variables
5e9afd6 
Signed-off-by: Josh Soref <[email protected]>
sfirke
sfirke approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@sfirke sfirke merged commit 041197b into apache:master Sep 29, 2023
28 checks passed
@jsoref jsoref deleted the spelling-docs branch September 29, 2023 13:52
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@jsoref
chore(docs): Spelling (apache#25453)
b5d60f1 
Signed-off-by: Josh Soref <[email protected]>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@jsoref
chore(docs): Spelling (apache#25453)
163d1eb 
Signed-off-by: Josh Soref <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfirke sfirke sfirke approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoref @sfirke @mistercrunch