refactor: Removes the deprecated DASHBOARD_FILTERS_EXPERIMENTAL feature flag

RESOURCES/FEATURE_FLAGS.md

@@ -88,7 +88,6 @@ These features flags currently default to True and **will be removed in a future
 
 - CLIENT_CACHE
 - DASHBOARD_CACHE
-- DASHBOARD_FILTERS_EXPERIMENTAL
 - DASHBOARD_NATIVE_FILTERS
 - DASHBOARD_NATIVE_FILTERS_SET
 - DISABLE_DATASET_SOURCE_EDIT

UPDATING.md

@@ -29,6 +29,8 @@ assists people when migrating to a new version.
 
 ### Breaking Changes
 
+- [26330](https://github.com/apache/superset/issues/26330): Removes the deprecated `DASHBOARD_FILTERS_EXPERIMENTAL` feature flag. The previous value of the feature flag was `False` and now the feature is permanently removed.
+
 ### Potential Downtime
 
 ### Other

superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts

@@ -27,7 +27,6 @@ export enum FeatureFlag {
   ALLOW_FULL_CSV_EXPORT = 'ALLOW_FULL_CSV_EXPORT',
   CLIENT_CACHE = 'CLIENT_CACHE',
   DASHBOARD_CROSS_FILTERS = 'DASHBOARD_CROSS_FILTERS',
-  DASHBOARD_FILTERS_EXPERIMENTAL = 'DASHBOARD_FILTERS_EXPERIMENTAL',
   CONFIRM_DASHBOARD_DIFF = 'CONFIRM_DASHBOARD_DIFF',
   DASHBOARD_NATIVE_FILTERS = 'DASHBOARD_NATIVE_FILTERS',
   DASHBOARD_NATIVE_FILTERS_SET = 'DASHBOARD_NATIVE_FILTERS_SET',

superset-frontend/src/dashboard/components/nativeFilters/utils.test.ts

@@ -94,10 +94,7 @@ describe('nativeFilterGate', () => {
       isFeatureEnabledMock = jest
         .spyOn(uiCore, 'isFeatureEnabled')
         .mockImplementation((featureFlag: FeatureFlag) =>
-          [
-            FeatureFlag.DASHBOARD_CROSS_FILTERS,
-            FeatureFlag.DASHBOARD_FILTERS_EXPERIMENTAL,
-          ].includes(featureFlag),
+          [FeatureFlag.DASHBOARD_CROSS_FILTERS].includes(featureFlag),
         );
     });
 

superset-frontend/src/dashboard/components/nativeFilters/utils.ts

@@ -150,8 +150,7 @@ export function getExtraFormData(
 export function nativeFilterGate(behaviors: Behavior[]): boolean {
   return (
     !behaviors.includes(Behavior.NATIVE_FILTER) ||
-    (isFeatureEnabled(FeatureFlag.DASHBOARD_FILTERS_EXPERIMENTAL) &&
-      isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS) &&
+    (isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS) &&
       behaviors.includes(Behavior.INTERACTIVE_CHART))
   );
 }