fix: Trino - handle table not found in SQLLab

[Khrol]

SUMMARY

SQLAlchemy doesn't strictly define what get_indexes method should do when table is not found.
Some dialects return the empty list while some of them raise NoSuchTableError.

When NoSuchTableError error is thrown, API returns 500 when non-existing table details are requested.
This PR fixes this issue and returns 404 in such cases.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Paste some non-existing table name in table name field and hit Enter:

Expected: no 500 errors from the backend.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea4e9a6) 69.16% compared to head (d7ff579) 69.16%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #26355   +/-   ##
=======================================
  Coverage   69.16%   69.16%           
=======================================
  Files        1948     1948           
  Lines       76054    76061    +7     
  Branches     8493     8493           
=======================================
+ Hits        52601    52608    +7     
  Misses      21273    21273           
  Partials     2180     2180           

Flag	Coverage Δ
hive	53.68% <42.85%> (-0.01%)	⬇️
mysql	78.06% <42.85%> (-0.01%)	⬇️
postgres	78.16% <42.85%> (-0.01%)	⬇️
presto	53.63% <42.85%> (-0.01%)	⬇️
python	82.86% <100.00%> (+<0.01%)	⬆️
sqlite	77.75% <42.85%> (-0.01%)	⬇️
unit	55.87% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[john-bodley]

Thanks @Khrol for the PR. It seems—as in this example—that the expected behavior for the extra_table_metadata() method is to return an empty dictionary if no indexes exist (assuming the underlying SQLAlchemy dialect returns an empty list as opposed to throwing a NoSuchTableError error.

From a consistency standpoint it seems like the preferred fix would be to augment the Database.get_indexes() method (or preferably the underlying engine spec get_indexes methods) to handle the NoSuchTableError error.

[john-bodley]

LGTM