Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump prophet to 1.1.5 #26431

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Conversation

villebro
Copy link
Member

@villebro villebro commented Jan 9, 2024

SUMMARY

Bump prophet to 1.1.5 which has binary distributions for Mac M1 and M2 chips. See full release notes here: https://github.com/facebook/prophet/releases/tag/1.1.5 Also recompile the deps files, as they appear to be out of sync again.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c2e818) 69.16% compared to head (ecf5460) 69.16%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26431      +/-   ##
==========================================
- Coverage   69.16%   69.16%   -0.01%     
==========================================
  Files        1948     1948              
  Lines       76042    76053      +11     
  Branches     8493     8493              
==========================================
+ Hits        52593    52600       +7     
- Misses      21269    21273       +4     
  Partials     2180     2180              
Flag Coverage Δ
hive 53.68% <ø> (-0.01%) ⬇️
mysql 78.07% <ø> (-0.01%) ⬇️
postgres 78.17% <ø> (-0.01%) ⬇️
presto 53.63% <ø> (-0.01%) ⬇️
python 82.85% <ø> (-0.01%) ⬇️
sqlite 77.76% <ø> (-0.01%) ⬇️
unit 55.86% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@john-bodley
Copy link
Member

@villebro could you confirm that the nasty bug in 1.1.4 has been resolved? Per #25017, @michael-s-molina previously had to revert a change which bumped the version of prophet to 1.1.4.

@villebro
Copy link
Member Author

villebro commented Jan 9, 2024

@villebro could you confirm that the nasty bug in 1.1.4 has been resolved? Per #25017, @michael-s-molina previously had to revert a change which bumped the version of prophet to 1.1.4.

Yep, it works for me, and as CI is passing, I don't see any big risk merging this one:

image

@villebro villebro merged commit a199356 into apache:master Jan 10, 2024
35 checks passed
@michael-s-molina michael-s-molina added the v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch label Jan 11, 2024
@villebro villebro deleted the villebro/prophet-1.1.5-2 branch January 11, 2024 17:14
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jan 16, 2024
michael-s-molina pushed a commit that referenced this pull request Jan 18, 2024
michael-s-molina pushed a commit that referenced this pull request Jan 18, 2024
sadpandajoe added a commit to preset-io/superset that referenced this pull request Jan 19, 2024
@mistercrunch mistercrunch added 🍒 3.0.4 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.0.4 🍒 3.1.1 🍒 3.1.2 🍒 3.1.3 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants