fix(drillby): Enable DrillBy in charts w/o filters (dimensions)

[sowo]

SUMMARY

This fix resolves #27940 by enabling "Drll by" for Timeseries and Mixed Timeseries charts that do not have dimensions configured.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After

TESTING INSTRUCTIONS

Open any dashboard that includes either Timeseries or Mixed Timeseries charts without dimensions and right-click on any data point in those charts. The "Drill by" should be available and open the modal for the selected dimension.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[rusackas]

Thanks @sowo this looks promising! Curious what you see left to do here, but we look forward to reviewing it when it's ready. So far, the code looks good to me!

[sowo]

Hi, Thanks for the response. I found an issue when clicking on the breadcrumbs. Some index misalignment after filtering out the empty initial filter. Should be fixed soon. Best, Wolfgang

…

On Mon, Apr 8, 2024 at 6:37 PM Evan Rusackas ***@***.***> wrote: Thanks @sowo <https://github.com/sowo> this looks promising! Curious what you see left to do here, but we look forward to reviewing it when it's ready. So far, the code looks good to me! — Reply to this email directly, view it on GitHub <#27941 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAVDI5JQDA7KHY2TYGGOGYDY4LBWLAVCNFSM6AAAAABF4YSE7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBTGIYDCMZSHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[rusackas]

/testenv up

[rusackas]

Maybe if @sfirke's hypothesis is right, we'll get lucky and this will help with #25334 as well... but maybe not. Just something to test when the ephemeral env spins up.

[sowo]

Seems the breadcrumbs and drillByConfigs need to be in sync to make breadcrumb navigation work. So rather than filtering out the first breadcrumb item when it is empty (for charts without dimensions), I decided to just hide the first breadcrumb. This is somewhat ugly as it leaves the separator (/) visible.

Let me know if anyone has a better idea on how to non-intrusively fix this.

[kgabryje]

/testenv up

[github-actions]

@kgabryje Ephemeral environment spinning up at http://35.89.213.150:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[kgabryje]

Thanks for the contribution @sowo! The code looks good to me. Feature wise, I think it would be great if we could have a drill filter based on X axis group, but that needs to be thought through first, so I'm fine with going with your change for now 🙂

[rusackas]

Hmm... closing/reopening to see if that kicks CI into gear.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[sowo]

@kgabryje initially, I used the X axis value plus the selected dimension for the drill by chart. But this created a time series chart with just one bar broken down by the selected dimension. For this to really be useful, the chart type would need to be changed - e.g. pie chart. Is there any plan to make the chart type selectable as one drills down?

Thanks

[sfirke]

Maybe if @sfirke's hypothesis is right, we'll get lucky and this will help with #25334 as well... but maybe not. Just something to test when the ephemeral env spins up.

Alas this did not, just confirmed while testing 4.0.1rc1 which contains this PR. This fix works through and is great!