feat(table): Table with Time Comparison #28057

Antonio-RiveroMartnez · 2024-04-16T13:45:11Z

SUMMARY

As part of the Time Comparison efforts, we are adding the new controls to the table viz.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Set up a table viz using the new time comparison controls

ADDITIONAL INFORMATION

Has associated issue: [SIP-119] Table Visualizations with Time Comparison Data #27432
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

Smallhi · 2024-04-19T09:02:12Z

@Antonio-RiveroMartnez can this feature support PIVOT TABLE ? I tested and found not.

Antonio-RiveroMartnez · 2024-04-23T21:40:55Z

@Antonio-RiveroMartnez can this feature support PIVOT TABLE ? I tested and found not.

Hey @Smallhi , so far it's not part of the pivot table as you pointed out. Once merged we can consider bringing this to other visualizations like pivot etc, thanks for asking.

Antonio-RiveroMartnez · 2024-04-24T00:10:41Z

/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true

github-actions · 2024-04-24T00:20:24Z

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://34.217.78.9:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Antonio-RiveroMartnez · 2024-04-24T13:43:29Z

/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true

github-actions · 2024-04-24T13:59:15Z

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://35.91.233.244:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

lilykuang · 2024-04-24T18:39:45Z

/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true

github-actions · 2024-04-24T18:51:11Z

@lilykuang Ephemeral environment spinning up at http://34.219.209.117:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Antonio-RiveroMartnez · 2024-04-25T13:33:23Z

/testenv up

github-actions · 2024-04-25T13:44:18Z

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://35.94.33.211:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Antonio-RiveroMartnez · 2024-04-25T15:18:13Z

/testenv up

github-actions · 2024-04-25T15:30:13Z

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://34.219.149.143:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Antonio-RiveroMartnez · 2024-04-25T16:29:01Z

/testenv up

github-actions · 2024-04-25T16:40:17Z

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://34.219.156.16:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Antonio-RiveroMartnez · 2024-04-26T12:59:00Z

/testenv up

github-actions · 2024-04-26T13:10:51Z

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://54.218.71.76:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

codecov-commenter · 2024-04-30T01:21:42Z

Codecov Report

Attention: Patch coverage is 42.90844% with 318 lines in your changes missing coverage. Please review.

Project coverage is 67.19%. Comparing base (76d897e) to head (7c262ef).
Report is 302 commits behind head on master.

Files	Patch %	Lines
...d/plugins/plugin-chart-table/src/transformProps.ts	22.58%	83 Missing and 13 partials ⚠️
...tend/plugins/plugin-chart-table/src/TableChart.tsx	24.24%	62 Missing and 13 partials ⚠️
.../explore/components/controls/TimeOffsetControl.tsx	1.42%	69 Missing ⚠️
...plore/components/controls/ComparisonRangeLabel.tsx	13.63%	19 Missing ⚠️
...ntend/plugins/plugin-chart-table/src/buildQuery.ts	45.16%	10 Missing and 7 partials ⚠️
...nd/plugins/plugin-chart-table/src/controlPanel.tsx	15.38%	10 Missing and 1 partial ⚠️
...Number/BigNumberPeriodOverPeriod/transformProps.ts	0.00%	9 Missing ⚠️
...onalFormattingControl/FormattingPopoverContent.tsx	10.00%	9 Missing ⚠️
.../BigNumber/BigNumberPeriodOverPeriod/buildQuery.ts	0.00%	7 Missing ⚠️
...ins/plugin-chart-table/src/DataTable/DataTable.tsx	25.00%	0 Missing and 3 partials ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #28057      +/-   ##
==========================================
+ Coverage   60.48%   67.19%   +6.70%     
==========================================
  Files        1931     1957      +26     
  Lines       76236    77825    +1589     
  Branches     8568     8940     +372     
==========================================
+ Hits        46114    52293    +6179     
+ Misses      28017    23342    -4675     
- Partials     2105     2190      +85

Flag	Coverage Δ
hive	`?`
javascript	`57.78% <42.90%> (+0.06%)`	⬆️
presto	`?`
unit	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Antonio-RiveroMartnez · 2024-04-30T08:26:03Z

/testenv up

Antonio-RiveroMartnez · 2024-05-21T14:54:29Z

/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true

github-actions · 2024-05-21T15:10:31Z

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://34.215.152.130:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

- Handle nullish case when parsing dates so we can fix test cases

Antonio-RiveroMartnez · 2024-05-21T20:22:05Z

/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true

github-actions · 2024-05-21T20:35:00Z

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://34.210.222.153:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

- Handle relative single dates - Adjust tests

Antonio-RiveroMartnez · 2024-05-22T14:01:46Z

/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true

github-actions · 2024-05-22T14:13:56Z

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://52.89.241.120:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

# Conflicts: # superset-frontend/src/explore/components/controls/ConditionalFormattingControl/FormattingPopoverContent.tsx

- Fix Relatives dates - Reset Custom date picker when date is invalid after switching from inherit - Handle custom ranges - Add tests to changes in shift calculation - Use timezone-mock so we can use different timezones in our tests and be certain things are working as expected Note: This is duplicating a method from controls, we must replace it entirely it and move to ui-core instead, but that should probably be a follow up commit

# Conflicts: # superset-frontend/plugins/plugin-chart-table/src/transformProps.ts

- fix lint - move all customTimeRangeDecode references to superset-ui

lilykuang · 2024-06-12T02:30:40Z

/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true

github-actions · 2024-06-12T02:42:51Z

@lilykuang Ephemeral environment spinning up at http://34.220.222.238:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions · 2024-06-14T18:22:15Z

Ephemeral environment shutdown and build artifacts deleted.

Co-authored-by: Lily Kuang <[email protected]> Co-authored-by: lilykuang <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]>

pull-request-size bot added the size/XXL label Apr 16, 2024

github-actions bot added api Related to the REST API plugins dependencies:npm packages labels Apr 16, 2024

Antonio-RiveroMartnez force-pushed the table-time-comparison-offset branch from b33cbcd to ea3ae4b Compare April 23, 2024 21:38

Antonio-RiveroMartnez force-pushed the table-time-comparison-offset branch from ea3ae4b to f03135e Compare April 23, 2024 22:01

Antonio-RiveroMartnez force-pushed the table-time-comparison-offset branch from ccada04 to e6cfe8a Compare April 25, 2024 14:57

Antonio-RiveroMartnez force-pushed the table-time-comparison-offset branch from e6cfe8a to 7b3316a Compare April 25, 2024 16:05

lilykuang force-pushed the table-time-comparison-offset branch 3 times, most recently from 7ebe84d to 1ffef74 Compare April 26, 2024 04:21

Antonio-RiveroMartnez removed request for dpgaspar, nytai and jinghua-qa May 20, 2024 23:06

Table with Time Comparison: fix getTimeOffset

2cf6134

Antonio-RiveroMartnez force-pushed the table-time-comparison-offset branch from aa307f2 to 244fd42 Compare May 21, 2024 15:49

Time Comparison:

0850d86

- Handle nullish case when parsing dates so we can fix test cases

Antonio-RiveroMartnez force-pushed the table-time-comparison-offset branch from 244fd42 to 0850d86 Compare May 21, 2024 16:21

Time Comparison:

a7c5b4e

- Handle relative single dates - Adjust tests

Merge remote-tracking branch 'origin/master' into HEAD

fdcaea4

# Conflicts: # superset-frontend/src/explore/components/controls/ConditionalFormattingControl/FormattingPopoverContent.tsx

lilykuang force-pushed the table-time-comparison-offset branch from 918c6cd to fdcaea4 Compare June 10, 2024 16:53

Antonio-RiveroMartnez and others added 6 commits June 10, 2024 21:59

Merge remote-tracking branch 'origin/master' into HEAD

bc5153f

# Conflicts: # superset-frontend/plugins/plugin-chart-table/src/transformProps.ts

TimeComparison:

a0cf8ca

- fix lint - move all customTimeRangeDecode references to superset-ui

TimeComparison: update test coverage for getTimeOffset

c3d6da9

TimeComparison: update test coverage for customTimeRangeDecode

3b07a2e

TimeComparison: remove duplicated customTimeRangeDecode

7c262ef

lilykuang force-pushed the table-time-comparison-offset branch from 3da32e7 to 7c262ef Compare June 12, 2024 02:08

eschutho approved these changes Jun 14, 2024

View reviewed changes

Antonio-RiveroMartnez merged commit 7ddea62 into apache:master Jun 14, 2024
39 checks passed

eschutho pushed a commit that referenced this pull request Jul 24, 2024

feat(table): Table with Time Comparison (#28057)

9c168f8

Co-authored-by: Lily Kuang <[email protected]> Co-authored-by: lilykuang <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]>

mapledan mentioned this pull request Sep 9, 2024

show summary does not correctly apply all filters #30193

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(table): Table with Time Comparison #28057

feat(table): Table with Time Comparison #28057

Antonio-RiveroMartnez commented Apr 16, 2024 •

edited

Loading

Smallhi commented Apr 19, 2024

Antonio-RiveroMartnez commented Apr 23, 2024

Antonio-RiveroMartnez commented Apr 24, 2024

github-actions bot commented Apr 24, 2024

Antonio-RiveroMartnez commented Apr 24, 2024

github-actions bot commented Apr 24, 2024

lilykuang commented Apr 24, 2024

github-actions bot commented Apr 24, 2024

Antonio-RiveroMartnez commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

Antonio-RiveroMartnez commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

Antonio-RiveroMartnez commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

Antonio-RiveroMartnez commented Apr 26, 2024

github-actions bot commented Apr 26, 2024

codecov-commenter commented Apr 30, 2024 •

edited by codecov bot

Loading

Antonio-RiveroMartnez commented Apr 30, 2024

Antonio-RiveroMartnez commented May 21, 2024

github-actions bot commented May 21, 2024

Antonio-RiveroMartnez commented May 21, 2024

github-actions bot commented May 21, 2024

Antonio-RiveroMartnez commented May 22, 2024

github-actions bot commented May 22, 2024

lilykuang commented Jun 12, 2024

github-actions bot commented Jun 12, 2024

github-actions bot commented Jun 14, 2024

feat(table): Table with Time Comparison #28057

feat(table): Table with Time Comparison #28057

Conversation

Antonio-RiveroMartnez commented Apr 16, 2024 • edited Loading

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Smallhi commented Apr 19, 2024

Antonio-RiveroMartnez commented Apr 23, 2024

Antonio-RiveroMartnez commented Apr 24, 2024

github-actions bot commented Apr 24, 2024

Antonio-RiveroMartnez commented Apr 24, 2024

github-actions bot commented Apr 24, 2024

lilykuang commented Apr 24, 2024

github-actions bot commented Apr 24, 2024

Antonio-RiveroMartnez commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

Antonio-RiveroMartnez commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

Antonio-RiveroMartnez commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

Antonio-RiveroMartnez commented Apr 26, 2024

github-actions bot commented Apr 26, 2024

codecov-commenter commented Apr 30, 2024 • edited by codecov bot Loading

Codecov Report

Antonio-RiveroMartnez commented Apr 30, 2024

Antonio-RiveroMartnez commented May 21, 2024

github-actions bot commented May 21, 2024

Antonio-RiveroMartnez commented May 21, 2024

github-actions bot commented May 21, 2024

Antonio-RiveroMartnez commented May 22, 2024

github-actions bot commented May 22, 2024

lilykuang commented Jun 12, 2024

github-actions bot commented Jun 12, 2024

github-actions bot commented Jun 14, 2024

Antonio-RiveroMartnez commented Apr 16, 2024 •

edited

Loading

codecov-commenter commented Apr 30, 2024 •

edited by codecov bot

Loading