Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maps): adds Crimea back to Ukraine 🇺🇦 #28226

Merged
merged 5 commits into from
Apr 25, 2024

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Apr 25, 2024

SUMMARY

Updates the Jupyter notebook to correct Natural Earth's data, and copy Crimea (back) onto Ukraine.

All references to Kiev are also now properly renamed to Kyiv

Czech Republic an Philippines Regions seem to be updated, as bycatch.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas requested a review from villebro as a code owner April 25, 2024 21:41
@github-actions github-actions bot added plugins doc Namespace | Anything related to documentation labels Apr 25, 2024
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM!
image

@rusackas rusackas merged commit 1e47e65 into master Apr 25, 2024
28 of 29 checks passed
@rusackas rusackas deleted the adding-crimea-to-ukraine-map branch April 26, 2024 03:42
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@last-partizan
Copy link

Oh, thank you for this commit.

Btw, maybe also remove Crimea from Russia map?

@michael-s-molina michael-s-molina added v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch and removed v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch labels Apr 29, 2024
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@mistercrunch mistercrunch added 🍒 4.0.1 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 24, 2024
@ZOY23
Copy link

ZOY23 commented Sep 10, 2024

Oh, thank you for this commit.

But you made a mistake, there are real boundaries in the screenshot.
6434702015

@defteame
Copy link

defteame commented Oct 3, 2024

@ZOY23 that's some cool fanfiction you have there (esp. Kherson lol), not sure how its related to real boundaries though?

@villebro
Copy link
Member

villebro commented Oct 3, 2024

@rusackas recently wrote a great blog post on how the Superset project manages country maps, and what our policies are regarding contested areas. I kindly request users refrain from getting into this debate here - if anyone wants to contest our policies, you are welcome to post to our dev list, or join our in-person monthly town hall, to see if the wider community shares your views.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc Namespace | Anything related to documentation plugins size/L v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 4.0.1 🍒 4.0.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants