Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): temporal column mixin #28241

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

justinpark
Copy link
Member

@justinpark justinpark commented Apr 26, 2024

SUMMARY

In order to address the issue of the isTemporal property not being calculated from the mapping state in temporalColumnMixin, this commit migrates the property to the override object property.
This change ensures that the 3rd party controlOverrides can be properly overridden.

TESTING INSTRUCTIONS

Big number with Trendline works as before

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@justinpark justinpark merged commit 743c0bd into apache:master Apr 29, 2024
30 of 31 checks passed
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Apr 29, 2024
michael-s-molina pushed a commit that referenced this pull request Apr 29, 2024
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@lokeshwar9
Copy link

lokeshwar9 commented Jul 4, 2024

hey, Greetings of the day.

I wonder, if this has anything related to the below issue.
if we deselect few temporal columns in edit dataset and sync columns at any later point of time.
The configuration i applied for temporal columns are all gone and superset is mapping the all the time columns in dataset as temporal.
does this merge retains my configuration?

Thanks

@mistercrunch mistercrunch added 🍒 4.0.1 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels packages size/S v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 4.0.1 🍒 4.0.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants