Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Color scheme control crashing when dashboardId present #28457

Merged
merged 2 commits into from
May 13, 2024
Merged

fix: Color scheme control crashing when dashboardId present #28457

merged 2 commits into from
May 13, 2024

Conversation

kgabryje
Copy link
Member

SUMMARY

Fix a bug introduced in #27995. When user opens a chart from dashboard, the color scheme control would crash.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

image

After:

image

TESTING INSTRUCTIONS

  1. Go to a dashboard
  2. Open in Explore a chart that has categorical color scheme control
  3. Verify that the control works, has value "Dashboard scheme" and is disabled

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kgabryje kgabryje merged commit 983f809 into apache:master May 13, 2024
32 of 33 checks passed
aehanno pushed a commit to kosmos-education/superset that referenced this pull request May 13, 2024
@kgabryje @aehanno
fix: Color scheme control crashing when dashboardId present (apache#2…
24c747a 
…8457)
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@kgabryje @jzhao62
fix: Color scheme control crashing when dashboardId present (apache#2…
fc071c3 
…8457)
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
@kgabryje @EnxDev
fix: Color scheme control crashing when dashboardId present (apache#2…
b3d719a 
…8457)
eschutho pushed a commit that referenced this pull request Jun 23, 2024
@kgabryje @sadpandajoe
fix: Color scheme control crashing when dashboardId present (#28457)
61bd2d3 
(cherry picked from commit 983f809)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido approved these changes

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kgabryje @geido