Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Unify all json.(loads|dumps) usage to utils.json #28702

Merged
merged 2 commits into from
May 28, 2024
+530 −480

Added pylint plugin import checker

774d3d1
Select commit
Loading
Failed to load commit list.
Merged

refactor: Unify all json.(loads|dumps) usage to utils.json #28702

Added pylint plugin import checker
774d3d1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 28, 2024 in 0s

83.47% (+22.98%) compared to 76d897e

View this Pull Request on Codecov

83.47% (+22.98%) compared to 76d897e

Details

Codecov Report

Attention: Patch coverage is 68.04734% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 83.47%. Comparing base (76d897e) to head (774d3d1).
Report is 233 commits behind head on master.

Files Patch % Lines
superset/extensions/pylint.py 0.00% 23 Missing ⚠️
superset/commands/dataset/export.py 25.00% 3 Missing ⚠️
superset/commands/dashboard/export.py 33.33% 2 Missing ⚠️
superset/views/chart/views.py 33.33% 2 Missing ⚠️
superset/charts/data/api.py 75.00% 1 Missing ⚠️
superset/commands/chart/export.py 50.00% 1 Missing ⚠️
superset/commands/chart/importers/v1/utils.py 50.00% 1 Missing ⚠️
superset/commands/database/export.py 50.00% 1 Missing ⚠️
superset/commands/database/validate.py 50.00% 1 Missing ⚠️
superset/commands/query/export.py 50.00% 1 Missing ⚠️
... and 18 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #28702       +/-   ##
===========================================
+ Coverage   60.48%   83.47%   +22.98%     
===========================================
  Files        1931      523     -1408     
  Lines       76236    37575    -38661     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31365    -14749     
+ Misses      28017     6210    -21807     
+ Partials     2105        0     -2105

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov