-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Unsupported Slack API calls #29532
fix: Unsupported Slack API calls #29532
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I think @eschutho is working on the same thing... hopefully we're not duplicating efforts. I've added her as a reviewer. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29532 +/- ##
===========================================
+ Coverage 60.48% 83.68% +23.19%
===========================================
Files 1931 523 -1408
Lines 76236 37633 -38603
Branches 8568 0 -8568
===========================================
- Hits 46114 31492 -14622
+ Misses 28017 6141 -21876
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thank you for the feedback! |
Thank you for the PR! We appreciate this, and any other contribution you're willing to make to the project. Feel free to reach out on slack if you ever want to discuss other opportunities to do so! |
SUMMARY
Issue/29480 invalid slack operation
I've used very naive approach of simply replacing method calls for 'files_upload', since the method using it has already been marked for deprecation inside Superset.
TESTING INSTRUCTIONS
Setup Slack Token API-based notification using dashboard.
Actually send the notification, instead of receiving API deprecation response from Slack.
ADDITIONAL INFORMATION