Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): missing column autocomplete in custom SQL #29672

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

justinpark
Copy link
Member

SUMMARY

The keywords field was missing in the Custom SQL editor of the column item, causing the autocomplete feature in the metrics field to be unavailable.
This commit fills in the missing keywords field in the Column component and adds styling to the tooltip section of the autocomplete feature.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

before--column-autocomplete.mov

After:

after--column-keywords.mov

TESTING INSTRUCTIONS

Open a column selector in explore
Click Custom SQL and type a column name

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added explore Namespace | Anything related to Explore tooltip:control labels Jul 23, 2024
<>
<Global
styles={css`
.ace_tooltip {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinpark I noticed that src/SqlLab/components/AceEditorWrapper/index.tsx has similar logic as this code. Is it possible to avoid code duplication in this case and also ensure similar behavior for both editors by using a single component?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @michael-s-molina and I discussed offline, the SqlLab/AceEditorWrapper component has styles associated with the SqlLab Editor, and this section applies the global ace-editor styles.

@justinpark justinpark force-pushed the fix--missing-column-autocomplete branch from 522707d to da1f147 Compare July 25, 2024 21:06
@justinpark justinpark merged commit 3c97145 into apache:master Jul 26, 2024
34 checks passed
@sadpandajoe
Copy link
Member

@supersetbot label 4.1

@github-actions github-actions bot added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Jul 30, 2024
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jul 30, 2024
@sadpandajoe
Copy link
Member

@supersetbot unlabel 4.1

@github-actions github-actions bot removed the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Aug 1, 2024
@justinpark
Copy link
Member Author

supersetbot unlabel 4.1

@sadpandajoe Is there a reason why this was excluded from version 4.1? Could you include this commit in 4.1?

@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Aug 15, 2024
@sadpandajoe
Copy link
Member

supersetbot unlabel 4.1

@sadpandajoe Is there a reason why this was excluded from version 4.1? Could you include this commit in 4.1?

Yeah i can grab it

sadpandajoe pushed a commit that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
explore Namespace | Anything related to Explore size/L tooltip:control v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants