-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docker): move mysql os-level deps (GPL) to dev image only #29771
Conversation
66c39c8
to
e9f95c8
Compare
Curious to see if Also, do you have any sense of what's causing the memory increase to the point of needing swap space? Probably unrelated to this, but a little disconcerting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker-build
step is failing, which seems important for this PR 😅
Right, not sure what's up with it, it looks like the job is getting killed, presumably because it's abusing memory usage (?) The confusing thing is we're actually installing less things in the step that fails. I tried a few things already:
I'm wondering what in this PR is pushing the memory usage (assuming that's why the job gets killed) over the edge, and it seems to indicate that the Next steps/ideas:
|
Since mysql client libs are GPL-licensed, we don't want to package them in our default images. Prior to this PR, the `default-libmysqlclient-dev` apt-get package would get installed in the `lean` docker image, though the pypi `mysqlclient` package that depends on this os-level dep was only installed in the `dev` layer. After this PR, all GPL/mysql related package won't be in `lean`, but still be in `dev` for convenience and CI script that test against mysql.
7759192
to
fce1c28
Compare
Since mysql client libs are GPL-licensed, we don't want to package them in our default images. Prior to this PR, the
default-libmysqlclient-dev
apt-get package would get installed in thelean
docker image, though the pypimysqlclient
package that depends on this os-level dep was only installed in thedev
layer.After this PR, all GPL/mysql related package won't be in
lean
, but still be indev
for convenience and CI script that test against mysql.