Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: HTML embedding of charts/dashboards without authentication #30032

Merged
merged 13 commits into from
Sep 18, 2024

Conversation

lindner-tj
Copy link
Contributor

@lindner-tj lindner-tj commented Aug 28, 2024

SUMMARY

Was trying to figure out how to embed dashboards/charts in other websites without SDK, came across this: #28407 I got it working and thought it would be a great addition to the docs.

PR is specifically for docs/docs/configuration/networking-settings.mdx

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

embedding2

TESTING INSTRUCTIONS

Add frame ancestors to Flask Talisman CSP, restart Superset and embed whatever public dashboard/chart you like

ADDITIONAL INFORMATION

  • Has associated issue: Embed charts with iframe without any login. #28407
  • Required feature flags:
  • Changes UI: docs only
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Aug 28, 2024
Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very nice addition, something that has been sorely missing from the documentation - thank you!! Let me know if you have questions or disagree with any of my suggestions.

docs/docs/configuration/networking-settings.mdx Outdated Show resolved Hide resolved
docs/docs/configuration/networking-settings.mdx Outdated Show resolved Hide resolved
docs/docs/configuration/networking-settings.mdx Outdated Show resolved Hide resolved
docs/docs/configuration/networking-settings.mdx Outdated Show resolved Hide resolved
docs/docs/configuration/networking-settings.mdx Outdated Show resolved Hide resolved
docs/docs/configuration/networking-settings.mdx Outdated Show resolved Hide resolved
docs/docs/configuration/networking-settings.mdx Outdated Show resolved Hide resolved
docs/docs/configuration/networking-settings.mdx Outdated Show resolved Hide resolved
@sfirke
Copy link
Member

sfirke commented Sep 18, 2024

Thanks @lindner-tj ! Sorry for the slow re-review.

@sfirke sfirke merged commit e54353c into apache:master Sep 18, 2024
34 of 35 checks passed
@lindner-tj
Copy link
Contributor Author

Thanks @lindner-tj ! Sorry for the slow re-review.

@sfirke no worries, thank you for merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Namespace | Anything related to documentation size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants