feat: reading language from url + resource type check fix #30318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
api
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
michael-s-molina
changed the title
villebro
reviewed
Sep 18, 2024
| r for r in user.resources if r["type"] == GuestTokenResourceType.DASHBOARD | ||
| r for r in user.resources if r["type"] == GuestTokenResourceType.DASHBOARD.value |
There was a problem hiding this comment.
I believe this was already fixed here: #30042
| @@ -111,6 +111,14 @@ export const URL_PARAMS = { | |||
| name: 'focused_chart', | |||
| type: 'number', | |||
| }, | |||
| language: { | |||
There was a problem hiding this comment.
I believe the correct parameter here should be locale which is comprised of both the language and region. Another point is that we should be able to infer the currency from the locale.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
fix(embedded dashboard): resource type was not checked appropriately against enum.
feat(UI): added currency and language to URL_PARAMS
feat(API): using language based on query parameter if found and defaulting to session value
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION