Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(explore): Medium font weight for section headers #30321

Merged
merged 1 commit into from
Sep 18, 2024
Merged

chore(explore): Medium font weight for section headers #30321

merged 1 commit into from
Sep 18, 2024

Conversation

kasiazjc
Copy link
Contributor

@kasiazjc kasiazjc commented Sep 18, 2024 •
edited
Loading

SUMMARY

Set font-weight: 500 for section headers in Explore's control panel.

This is one of a few incoming PRs to improve the visual balance in the control panel + fix readability after uppercase changes in control panel.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

image

After:

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the explore:design Related to the Explore UI/UX label Sep 18, 2024
mistercrunch
mistercrunch approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina
Copy link
Member

I believe there's a conflict of interest and @kgabryje should not be able to approve @kasiazjc's PRs 😛 😍

@kgabryje
Copy link
Member

I believe there's a conflict of interest and @kgabryje should not be able to approve @kasiazjc's PRs 😛 😍

I had to, no dinner otherwise

@kasiazjc
Copy link
Contributor Author

kasiazjc commented Sep 18, 2024 •
edited
Loading

I believe there's a conflict of interest and @kgabryje should not be able to approve @kasiazjc's PRs 😛 😍

I had to, no dinner otherwise

a lie, obviously, he just keeps an eye on new prs 🤷

@kasiazjc kasiazjc merged commit 930078b into apache:master Sep 18, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

@kgabryje kgabryje kgabryje approved these changes

@yousoph yousoph Awaiting requested review from yousoph

Assignees
No one assigned
Labels
explore:design Related to the Explore UI/UX size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kasiazjc @michael-s-molina @kgabryje @mistercrunch