-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(table): Use extras in queries #30335
Merged
Antonio-RiveroMartnez
merged 3 commits into
apache:master
from
Antonio-RiveroMartnez:fix_table_extras_query
Sep 19, 2024
Merged
fix(table): Use extras in queries #30335
Antonio-RiveroMartnez
merged 3 commits into
apache:master
from
Antonio-RiveroMartnez:fix_table_extras_query
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
change:frontend
Requires changing the frontend
viz:charts:table
Related to the Table chart
labels
Sep 19, 2024
Antonio-RiveroMartnez
changed the title
fix(table): Use extras in query only remove time_grain_sqla when not needed
fix(table): Use extras in queries
Sep 19, 2024
Antonio-RiveroMartnez
force-pushed
the
fix_table_extras_query
branch
from
September 19, 2024 11:56
cff717f
to
ecc2376
Compare
Antonio-RiveroMartnez
requested review from
kgabryje,
geido and
michael-s-molina
and removed request for
a team
September 19, 2024 11:58
giftig
reviewed
Sep 19, 2024
giftig
reviewed
Sep 19, 2024
superset-frontend/plugins/plugin-chart-table/test/buildQuery.test.ts
Outdated
Show resolved
Hide resolved
giftig
reviewed
Sep 19, 2024
giftig
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions but LGTM
… removed - DRY on test file - fix typos
giftig
approved these changes
Sep 19, 2024
3 tasks
sadpandajoe
added
the
v4.1
Label added by the release manager to track PRs to be included in the 4.1 branch
label
Sep 19, 2024
sadpandajoe
pushed a commit
that referenced
this pull request
Sep 19, 2024
(cherry picked from commit 6c2bd2a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
change:frontend
Requires changing the frontend
plugins
size/M
v4.1
Label added by the release manager to track PRs to be included in the 4.1 branch
viz:charts:table
Related to the Table chart
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Table
chart was removing theextras
from the summary query, assuming they were only used for time grains. This PR fixes that and put the extras back in the queryObject sent as payload, now, only excludingtime_grain_sqla
if no temporal column is included in your chart.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: Excluding extras from summary query and only adding it if no time comparison was used
Now: Sending extras in the total query regardless you're using time comparison
No temporal Column
With temporal Column
TESTING INSTRUCTIONS
Table
ChartShow summary
checkboxwhere
in extras for both queries and not include atime_grain_sqla
time_grain_sqla
must be present in the extras alongside with thewhere
clauseADDITIONAL INFORMATION
show summary
does not correctly apply all filters #30193