-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: split cypress files for less memory #30354
Conversation
50c30a1
to
650b5c8
Compare
Matrix (1, chrome) failed so I restarted it manually. For the record Wondering if a wider matrix would help. Also it seems we have 5 * chrome now, but could try running also against Firefox to see if the memory consuption is more or less of a problem on that browser. |
Yes, that is the hot spot, and it's always the one that fails. We've also seen GitHub issues about performance regressions when there are lots of filters, so this failure is likely reflecting a real problem. We can throw memory, split tests, reduce test scope, etc. to smooth out devEx, but I think we're just dancing around a real problem. |
@rusackas this is passing CI.. I ran it again and had no errors.. can we try to merge it and test it out on master? |
Giving a shot at troubleshooting memory here -> #30397 , seems promising |
(cherry picked from commit 43721f1)
SUMMARY
Testing to see if this will fix the cypress memory issues.
Also added the chrome flag
disable-dev-shm-usage
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION