Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(websocket): upgrade ESLint to v9 #30359

Merged
merged 1 commit into from
Sep 22, 2024
Merged

build(websocket): upgrade ESLint to v9 #30359

merged 1 commit into from
Sep 22, 2024

Conversation

hainenber
Copy link
Contributor

build(websocket): upgrade ESLint to v9

SUMMARY

Upgrade to ESLint v9 for superset-websocket

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the javascript Dependabot - Pull requests that update Javascript code label Sep 22, 2024
mistercrunch
mistercrunch reviewed Sep 22, 2024
View reviewed changes
superset-websocket/eslint.config.js
@@ -0,0 +1,53 @@
/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: would have been great to git mv the file instead of what I'm guessing was a simple mv, which would make the PR easier to review

mistercrunch
mistercrunch approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing this forward!

@mistercrunch mistercrunch merged commit 55d9d57 into apache:master Sep 22, 2024
35 of 37 checks passed
@hainenber hainenber deleted the upgrade-eslint-to-v9 branch September 23, 2024 00:01
@michael-s-molina michael-s-molina added review:checkpoint Last PR reviewed during the daily review standup and removed review:checkpoint Last PR reviewed during the daily review standup labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

Assignees
No one assigned
Labels
dependencies:npm javascript Dependabot - Pull requests that update Javascript code size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hainenber @mistercrunch @michael-s-molina