Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing thumbsnails when switching viz #313

Merged
merged 3 commits into from
Apr 11, 2016
Merged

Showing thumbsnails when switching viz #313

merged 3 commits into from
Apr 11, 2016

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch mentioned this pull request Apr 10, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.335% when pulling fd3502b on thumbs into da421bb on master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling fd3502b on airbnb:thumbs into da421bb on airbnb:master.

1 similar comment
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling fd3502b on airbnb:thumbs into da421bb on airbnb:master.

@williaster
Copy link
Contributor

nice! I think eventually it'd be sweet to have more generic svg outlines, etc. but for now I think screenshots are okay / way better than nothing.

LGTM after rebase?

@sid88in
Copy link
Contributor

sid88in commented Apr 11, 2016

SO COOL

@sid88in
Copy link
Contributor

sid88in commented Apr 11, 2016

IMO we should make these widgets configurable. For instance, sometimes a given widget is not useful for certain distribution of data. In that case users can still see the widgets available in the drop down. Can we make these widgets configurable so that it can be customized by admin. - Just a thought ;)

@mistercrunch
Copy link
Member Author

@sid88in , yeah we could eventually have global settings (withelist/blacklist), and same at the datasource level perhaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants