Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent people from deleting datasources that have associate slices #3163

Merged
merged 1 commit into from
Jul 19, 2017

Conversation

mistercrunch
Copy link
Member

We've had people deleting datasources without knowing that other slices/dashboard were making use of them, breaking things. This should prevent that from happening.

This PR is also breaking down superset/connectors/base.py into a folder that aligns better with the related sqla and druid folders.

Ideally FAB would have something like the Django admin where it cascades deletes, but prompts the user first showing the tree of related objects getting deleted.

@coveralls
Copy link

coveralls commented Jul 19, 2017

Coverage Status

Coverage decreased (-0.002%) to 69.268% when pulling 6c89e82 on mistercrunch:delete_datasource into c34df3e on apache:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 69.268% when pulling 6c89e82 on mistercrunch:delete_datasource into c34df3e on apache:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 69.268% when pulling 6c89e82 on mistercrunch:delete_datasource into c34df3e on apache:master.

@mistercrunch mistercrunch merged commit a141695 into apache:master Jul 19, 2017
@mistercrunch mistercrunch deleted the delete_datasource branch July 19, 2017 23:24
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants