Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore update button labels #3534

Merged
merged 5 commits into from
Sep 28, 2017

Conversation

timifasubaa
Copy link
Contributor

It's not really clear from the button names the difference between both buttons.
@mistercrunch

@xrmx
Copy link
Contributor

xrmx commented Sep 27, 2017

Maybe not clear from their names but from the context where they are placed it shouldn't be hard to sort out what they do though.

@timifasubaa
Copy link
Contributor Author

It's still not obvious when you factor in the location. On the sql editor page, we explicitly state what the button does "Run Query" and "Save Query" to make it clear what you're doing with the query. This should make it more consistent.

screen shot 2017-09-27 at 10 39 09 am

@coveralls
Copy link

coveralls commented Sep 27, 2017

Coverage Status

Coverage remained the same at 70.06% when pulling 14ec8a5 on timifasubaa:explore--update_button_labels into f829b48 on apache:master.

@coveralls
Copy link

coveralls commented Sep 28, 2017

Coverage Status

Coverage increased (+0.1%) to 70.161% when pulling 7c61f1b on timifasubaa:explore--update_button_labels into f829b48 on apache:master.

@mistercrunch
Copy link
Member

Our designer approves of these minor changes, mergin'

@mistercrunch mistercrunch merged commit 82b85d1 into apache:master Sep 28, 2017
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
* resolve ui ambiguity

* resolve button name ambiguity

* update test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.1 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants