[New Viz] Nightingale Rose Chart #3676
Conversation
Mogball
force-pushed
the
mogball/feature/rose_chart
branch
2 times, most recently
from
700defc
to
4b7789f
Compare
Mogball
changed the title
|
Coverage increased (+0.8%) to 71.135% when pulling 4b7789f204055518bac067dd23e3b5b558ab8669 on Mogball:mogball/feature/rose_chart into d0b5b44 on apache:master. |
Mogball
force-pushed
the
mogball/feature/rose_chart
branch
from
4b7789f
to
e06214b
Compare
|
Coverage increased (+0.8%) to 71.147% when pulling aa9d96b17f05bdb2e63e933d0af7e2165c866de1 on Mogball:mogball/feature/rose_chart into 2a89c90 on apache:master. |
3 similar comments
|
Coverage increased (+0.8%) to 71.147% when pulling aa9d96b17f05bdb2e63e933d0af7e2165c866de1 on Mogball:mogball/feature/rose_chart into 2a89c90 on apache:master. |
|
Coverage increased (+0.8%) to 71.147% when pulling aa9d96b17f05bdb2e63e933d0af7e2165c866de1 on Mogball:mogball/feature/rose_chart into 2a89c90 on apache:master. |
|
Coverage increased (+0.8%) to 71.147% when pulling aa9d96b17f05bdb2e63e933d0af7e2165c866de1 on Mogball:mogball/feature/rose_chart into 2a89c90 on apache:master. |
Mogball
force-pushed
the
mogball/feature/rose_chart
branch
from
aa9d96b
to
e06214b
Compare
Mogball
force-pushed
the
mogball/feature/rose_chart
branch
from
b8dbe4f
to
38ecc7c
Compare
1 similar comment
| @@ -0,0 +1,540 @@ | |||
| /* eslint no-use-before-define: ["error", { "functions": false }] */ | |||
There was a problem hiding this comment.
This should probably just be an js file instead of jsx
| let inTransition = false; | ||
| const ae = roseWrap | ||
| .selectAll('g') | ||
| .data(JSON.parse(JSON.stringify(arcSt.data))) // deep copy data state |
There was a problem hiding this comment.
why does this need to be deep copied?
There was a problem hiding this comment.
The object passed to .data() becomes the 'state' of the arcs and is modified when they transition. arcSt.data needs to be copied so that the arcs can transition back to their original position.
| endAngle: nArcSt.pie[segments[0] + d.arcId].endAngle, | ||
| })(d)) | ||
| .style('opacity', d => | ||
| state.disabled[d.arcId] || arcSt.pie[segments[0] + d.arcId].percent < labelThreshold ? |
There was a problem hiding this comment.
I like parenthesis for these kinds of expressions.
Mogball
force-pushed
the
mogball/feature/rose_chart
branch
2 times, most recently
from
d1920a7
to
9c434bf
Compare
Mogball
force-pushed
the
mogball/feature/rose_chart
branch
from
9c434bf
to
d507380
Compare
|
@mistercrunch I would also like to bump this one |
|
@Mogball can you fix the merge conflicts? |
* Nightingale Rose Chart * Review comments
* Nightingale Rose Chart * Review comments
mistercrunch
added
🏷️ bot
Also known as a Polar Area Diagram, the Nightingale Rose Chart displays time series data on a polar coordinate system. The Rose Chart is meant to visualize periodic data (i.e. daily, weekly, monthly) to show variation over that cycle.
Features